Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 10407019: Extend assembler with ability to produce comments for the generated code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/disassembler_ia32.cc
diff --git a/runtime/vm/disassembler_ia32.cc b/runtime/vm/disassembler_ia32.cc
index 24ca193e55b53a7515c5bfcaa85d32e9e52586ea..572bda195c6a5d7ae1aac0924e871e6f26558635 100644
--- a/runtime/vm/disassembler_ia32.cc
+++ b/runtime/vm/disassembler_ia32.cc
@@ -1577,7 +1577,9 @@ int Disassembler::DecodeInstruction(char* hex_buffer, intptr_t hex_size,
void Disassembler::Disassemble(uword start,
uword end,
- DisassemblyFormatter* formatter) {
+ DisassemblyFormatter* formatter,
+ CodeComments comments) {
srdjan 2012/05/17 17:22:08 const CodeComments&
Vyacheslav Egorov (Google) 2012/05/17 21:16:27 Done.
+ // TODO(vegorov) Decode and display comments.
ASSERT(formatter != NULL);
char hex_buffer[kHexadecimalBufferSize]; // Instruction in hexadecimal form.
char human_buffer[kUserReadableBufferSize]; // Human-readable instruction.

Powered by Google App Engine
This is Rietveld 408576698