Extend assembler with ability to produce comments for the generated code.

runtime/vm/disassembler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 #include "platform/utils.h"
 #include "vm/allocation.h"
@@ skipping 1559 matching lines @@
     hex_index += 2;
     remaining_size -= 2;
   }
   hex_buffer[hex_index] = '\0';
   return instruction_length;
 }
 
 
 void Disassembler::Disassemble(uword start,
                                uword end,
-                               DisassemblyFormatter* formatter) {
+                               DisassemblyFormatter* formatter,
+                               const Code::Comments& comments) {
+  // TODO(vegorov) Decode and display comments.

[srdjan, 2012/05/17 21:30:37]

Typically: "TODO(vegorov):" (add colon).

   ASSERT(formatter != NULL);
   char hex_buffer[kHexadecimalBufferSize];  // Instruction in hexadecimal form.
   char human_buffer[kUserReadableBufferSize];  // Human-readable instruction.
   uword pc = start;
   while (pc < end) {
     int instruction_length = DecodeInstruction(hex_buffer,
                                                sizeof(hex_buffer),
                                                human_buffer,
                                                sizeof(human_buffer),
                                                pc);
     formatter->ConsumeInstruction(hex_buffer,
                                   sizeof(hex_buffer),
                                   human_buffer,
                                   sizeof(human_buffer),
                                   pc);
     pc += instruction_length;
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32