Extend assembler with ability to produce comments for the generated code.

runtime/vm/disassembler.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_DISASSEMBLER_H_
 #define VM_DISASSEMBLER_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/globals.h"
@@ skipping 44 matching lines @@
 };
 
 
 // Disassemble instructions.
 class Disassembler : public AllStatic {
  public:
   // Disassemble instructions between start and end.
   // (The assumption is that start is at a valid instruction).
   static void Disassemble(uword start,
                           uword end,
-                          DisassemblyFormatter* formatter);
+                          DisassemblyFormatter* formatter,
+                          CodeComments comments);

[srdjan, 2012/05/17 17:22:08]

const CodeComments& comments

[Vyacheslav Egorov (Google), 2012/05/17 21:16:27]

Done.

+
+  static void Disassemble(uword start,
+                          uword end,
+                          DisassemblyFormatter* formatter) {
+    Disassemble(start, end, formatter, CodeComments::New(0));
+  }
+
+  static void Disassemble(uword start, uword end, CodeComments comments) {
+    DisassembleToStdout stdout_formatter;
+    Disassemble(start, end, &stdout_formatter, comments);
+  }
+
   static void Disassemble(uword start, uword end) {
     DisassembleToStdout stdout_formatter;
     Disassemble(start, end, &stdout_formatter);
   }
 
   // Disassemble instructions in a memory region.
   static void DisassembleMemoryRegion(const MemoryRegion& instructions,
                                       DisassemblyFormatter* formatter) {
     uword start = instructions.start();
     uword end = instructions.end();
     Disassemble(start, end, formatter);
   }
+
   static void DisassembleMemoryRegion(const MemoryRegion& instructions) {
     uword start = instructions.start();
     uword end = instructions.end();
     Disassemble(start, end);
   }
 
   // Decodes one instruction.
   // Writes a hexadecimal representation into the hex_buffer and a
   // human-readable representation into the human_buffer.
   // Returns the length of the decoded instruction in bytes.
   static int DecodeInstruction(char* hex_buffer, intptr_t hex_size,
                                char* human_buffer, intptr_t human_size,
                                uword pc);
 
  private:
   static const int kHexadecimalBufferSize = 32;
   static const int kUserReadableBufferSize = 256;
 };
 
 }  // namespace dart
 
 #endif  // VM_DISASSEMBLER_H_