Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: sync/notifier/chrome_invalidation_client_unittest.cc

Issue 10407014: Rename InvalidationVersionTracker to InvalidationStateTracker in preparation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/chrome_invalidation_client.cc ('k') | sync/notifier/invalidation_notifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/chrome_invalidation_client_unittest.cc
===================================================================
--- sync/notifier/chrome_invalidation_client_unittest.cc (revision 137567)
+++ sync/notifier/chrome_invalidation_client_unittest.cc (working copy)
@@ -46,9 +46,9 @@
MOCK_METHOD1(OnSessionStatusChanged, void(bool));
};
-class MockInvalidationVersionTracker
- : public InvalidationVersionTracker,
- public base::SupportsWeakPtr<MockInvalidationVersionTracker> {
+class MockInvalidationStateTracker
+ : public InvalidationStateTracker,
+ public base::SupportsWeakPtr<MockInvalidationStateTracker> {
public:
MOCK_CONST_METHOD0(GetAllMaxVersions, InvalidationVersionMap());
MOCK_METHOD2(SetMaxVersion, void(syncable::ModelType, int64));
@@ -67,7 +67,7 @@
client_.Start(kClientId, kClientInfo, kState,
InvalidationVersionMap(),
browser_sync::MakeWeakHandle(
- mock_invalidation_version_tracker_.AsWeakPtr()),
+ mock_invalidation_state_tracker_.AsWeakPtr()),
&mock_listener_, &mock_state_writer_,
fake_base_task_.AsWeakPtr());
}
@@ -98,7 +98,7 @@
EXPECT_CALL(mock_invalidation_client_, Acknowledge(ack_handle));
client_.Invalidate(&mock_invalidation_client_, inv, ack_handle);
// Pump message loop to trigger
- // InvalidationVersionTracker::SetMaxVersion().
+ // InvalidationStateTracker::SetMaxVersion().
message_loop_.RunAllPending();
}
@@ -121,8 +121,8 @@
MessageLoop message_loop_;
StrictMock<MockListener> mock_listener_;
- StrictMock<MockInvalidationVersionTracker>
- mock_invalidation_version_tracker_;
+ StrictMock<MockInvalidationStateTracker>
+ mock_invalidation_state_tracker_;
StrictMock<MockStateWriter> mock_state_writer_;
StrictMock<MockInvalidationClient> mock_invalidation_client_;
notifier::FakeBaseTask fake_base_task_;
@@ -156,7 +156,7 @@
TEST_F(ChromeInvalidationClientTest, InvalidateNoPayload) {
EXPECT_CALL(mock_listener_,
OnInvalidate(MakeMap(syncable::BOOKMARKS, "")));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::BOOKMARKS, 1));
FireInvalidate("BOOKMARK", 1, NULL);
}
@@ -164,7 +164,7 @@
TEST_F(ChromeInvalidationClientTest, InvalidateWithPayload) {
EXPECT_CALL(mock_listener_,
OnInvalidate(MakeMap(syncable::PREFERENCES, "payload")));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::PREFERENCES, 1));
FireInvalidate("PREFERENCE", 1, "payload");
}
@@ -174,7 +174,7 @@
EXPECT_CALL(mock_listener_,
OnInvalidate(MakeMap(syncable::APPS, "")));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::APPS, 1));
// Should trigger.
@@ -207,9 +207,9 @@
EXPECT_CALL(mock_listener_,
OnInvalidate(MakeMap(syncable::EXTENSIONS, "")));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::APPS, 3));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::EXTENSIONS, 2));
// Should trigger both.
@@ -217,21 +217,21 @@
FireInvalidate("EXTENSION", 2, NULL);
Mock::VerifyAndClearExpectations(&mock_listener_);
- Mock::VerifyAndClearExpectations(&mock_invalidation_version_tracker_);
+ Mock::VerifyAndClearExpectations(&mock_invalidation_state_tracker_);
// Should both be dropped.
FireInvalidate("APP", 1, NULL);
FireInvalidate("EXTENSION", 1, NULL);
Mock::VerifyAndClearExpectations(&mock_listener_);
- Mock::VerifyAndClearExpectations(&mock_invalidation_version_tracker_);
+ Mock::VerifyAndClearExpectations(&mock_invalidation_state_tracker_);
// InvalidateAll shouldn't change any version state.
EXPECT_CALL(mock_listener_, OnInvalidate(MakeMapFromSet(types, "")));
FireInvalidateAll();
Mock::VerifyAndClearExpectations(&mock_listener_);
- Mock::VerifyAndClearExpectations(&mock_invalidation_version_tracker_);
+ Mock::VerifyAndClearExpectations(&mock_invalidation_state_tracker_);
EXPECT_CALL(mock_listener_,
OnInvalidate(MakeMap(syncable::PREFERENCES, "")));
@@ -240,11 +240,11 @@
EXPECT_CALL(mock_listener_,
OnInvalidate(MakeMap(syncable::APPS, "")));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::PREFERENCES, 5));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::EXTENSIONS, 3));
- EXPECT_CALL(mock_invalidation_version_tracker_,
+ EXPECT_CALL(mock_invalidation_state_tracker_,
SetMaxVersion(syncable::APPS, 4));
// Should trigger all three.
« no previous file with comments | « sync/notifier/chrome_invalidation_client.cc ('k') | sync/notifier/invalidation_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698