Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10407014: Rename InvalidationVersionTracker to InvalidationStateTracker in preparation (Closed)

Created:
8 years, 7 months ago by Munjal (Google)
Modified:
8 years, 7 months ago
Reviewers:
akalin, lipalani1
CC:
chromium-reviews, Raghu Simha, ncarter (slow), pam+watch_chromium.org, akalin, tim (not reviewing)
Visibility:
Public.

Description

Rename InvalidationVersionTracker to InvalidationStateTracker in preparation to add more methods to that class. BUG=124140 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137685

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -133 lines) Patch
M chrome/browser/sync/glue/sync_backend_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sync/notifier/chrome_invalidation_client.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M sync/notifier/chrome_invalidation_client.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M sync/notifier/chrome_invalidation_client_unittest.cc View 1 10 chunks +18 lines, -18 lines 0 comments Download
M sync/notifier/invalidation_notifier.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M sync/notifier/invalidation_notifier.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/invalidation_notifier_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + sync/notifier/invalidation_state_tracker.h View 3 chunks +6 lines, -7 lines 0 comments Download
D sync/notifier/invalidation_version_tracker.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/sync_notifier_factory.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M sync/notifier/sync_notifier_factory.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M sync/notifier/sync_notifier_factory_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sync/sync.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Munjal (Google)
8 years, 7 months ago (2012-05-16 23:41:57 UTC) #1
akalin
LGTM
8 years, 7 months ago (2012-05-16 23:44:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10407014/1
8 years, 7 months ago (2012-05-16 23:46:39 UTC) #3
commit-bot: I haz the power
Can't apply patch for file sync/notifier/invalidation_state_tracker.h. While running patch -p0 --forward --force; patching file sync/notifier/invalidation_state_tracker.h ...
8 years, 7 months ago (2012-05-16 23:46:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10407014/43
8 years, 7 months ago (2012-05-17 17:35:35 UTC) #5
commit-bot: I haz the power
Can't apply patch for file sync/notifier/invalidation_state_tracker.h. While running patch -p0 --forward --force; patching file sync/notifier/invalidation_state_tracker.h ...
8 years, 7 months ago (2012-05-17 17:36:01 UTC) #6
Munjal (Google)
8 years, 7 months ago (2012-05-17 18:43:24 UTC) #7 
LGTM

Sorry, I mistakenly thought I had run try jobs successfully on this patch.

Powered by Google App Engine
This is Rietveld 408576698