Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 10407013: Minor GDataDB fixes. (Closed)

Created:
8 years, 7 months ago by achuithb
Modified:
8 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Minor GDataDB fixes. * Add AssertIOAllowed to GDataLevelDB. * Remove entry_set_. Use AddEntry for ownership transfer to parent directory. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138315

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M chrome/browser/chromeos/gdata/gdata_db_unittest.cc View 1 2 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_leveldb.cc View 1 10 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
Is AssertIOAllowed the best way to test that we're not on the UI thread for ...
8 years, 7 months ago (2012-05-21 19:43:17 UTC) #1
satorux1
LGTM. I also have no idea about a better way.
8 years, 7 months ago (2012-05-21 20:09:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10407013/6001
8 years, 7 months ago (2012-05-21 21:43:37 UTC) #3
commit-bot: I haz the power
Try job failure for 10407013-6001 (retry) on win for step "update" (clobber build). It's a ...
8 years, 7 months ago (2012-05-21 22:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10407013/6001
8 years, 7 months ago (2012-05-21 22:26:57 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 03:37:28 UTC) #6
Try job failure for 10407013-6001 (retry) on win_rel for steps "base_unittests,
sync_unit_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698