Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 10407009: Add GetIOMessageLoopProxy method to RenderThread interface. (Closed)

Created:
8 years, 7 months ago by bbudge
Modified:
8 years, 7 months ago
Reviewers:
jam, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Add GetIOMessageLoopProxy method to RenderThread interface. This is needed to set up a PPAPI HostDispatcher in Chrome code, so we can work on the NaCl IPC proxy outside of src/content. BUG=116317 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137604

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/public/renderer/render_thread.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/mock_render_thread.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/mock_render_thread.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bbudge
8 years, 7 months ago (2012-05-16 21:22:12 UTC) #1
jam
missing the impls.. http://codereview.chromium.org/10407009/diff/1/content/public/renderer/render_thread.h File content/public/renderer/render_thread.h (right): http://codereview.chromium.org/10407009/diff/1/content/public/renderer/render_thread.h#newcode46 content/public/renderer/render_thread.h:46: virtual scoped_refptr<base::MessageLoopProxy> GetIOLoopProxy() = 0; nit: ...
8 years, 7 months ago (2012-05-16 22:25:23 UTC) #2
bbudge
http://codereview.chromium.org/10407009/diff/1/content/public/renderer/render_thread.h File content/public/renderer/render_thread.h (right): http://codereview.chromium.org/10407009/diff/1/content/public/renderer/render_thread.h#newcode46 content/public/renderer/render_thread.h:46: virtual scoped_refptr<base::MessageLoopProxy> GetIOLoopProxy() = 0; On 2012/05/16 22:25:23, John ...
8 years, 7 months ago (2012-05-16 23:16:15 UTC) #3
bbudge
Missed MockRenderThread, another implementor of RenderThread.
8 years, 7 months ago (2012-05-16 23:29:52 UTC) #4
jam
lgtm
8 years, 7 months ago (2012-05-16 23:52:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/10407009/3004
8 years, 7 months ago (2012-05-16 23:57:10 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 01:37:35 UTC) #7
Change committed as 137604

Powered by Google App Engine
This is Rietveld 408576698