Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 10407006: P0 - Fix output locations of syzygy versions of mini_installer's PDB and Map files. (Closed)

Created:
8 years, 7 months ago by Roger McFarlane (Chromium)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Fix output locations of syzygy versions of mini_installer's PDB and Map files. The default paths have changed under from Visual Studio 2008 to 2010 and which causes the PDB and MAP files for the syzygyized mini_installer to get generated to the same locations as for the regular mini_installer. This further causes the staging of the Syzygy optimized build to fail because it expects the PDB file to be somewhere else. Made the paths of the PDB and MAP files explicit. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/installer/mini_installer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kerz_chromium
lgtm
8 years, 7 months ago (2012-05-16 20:00:40 UTC) #1
robertshield
lgtm
8 years, 7 months ago (2012-05-16 20:02:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerm@chromium.org/10407006/1
8 years, 7 months ago (2012-05-16 20:30:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerm@chromium.org/10407006/1
8 years, 7 months ago (2012-05-16 22:39:05 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 00:25:28 UTC) #5
Change committed as 137580

Powered by Google App Engine
This is Rietveld 408576698