Issue 10407003: Fix Mac shared component build following r137235

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10407003: Fix Mac shared component build following r137235 (Closed)

Created:
8 years, 7 months ago by Mark Mentovai

Modified:
8 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix Mac shared component build following r137235. BUG=108238 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137441

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	base/mac/foundation_util.h	View		2 chunks	+7 lines, -1 line	1 comment	Download
	M	base/mac/foundation_util.mm	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm, thanks! https://chromiumcodereview.appspot.com/10407003/diff/1/base/mac/foundation_util.h File base/mac/foundation_util.h (right): https://chromiumcodereview.appspot.com/10407003/diff/1/base/mac/foundation_util.h#newcode37 base/mac/foundation_util.h:37: typedef struct OpaqueSecTrustedApplicationRef* SecTrustedApplicationRef; I think it's ...

8 years, 7 months ago (2012-05-16 16:55:11 UTC) #2

Mark Mentovai

8 years, 7 months ago (2012-05-16 16:57:42 UTC) #3

The alternative is to have CFCast implementations (and now headers because of
the shared component build) proliferate across the codebase. I think it’s
preferable to keep everything consolidated in CFCast.

Expand Messages | Collapse Messages