Add special handling of the content type HTTP header

tests/standalone/io/http_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=
 // VMOptions=--short_socket_read
 // VMOptions=--short_socket_write
 // VMOptions=--short_socket_read --short_socket_write
 
 #import("dart:isolate");
@@ skipping 136 matching lines @@
   // Set the "Expires" header.
   void _expires2Handler(HttpRequest request, HttpResponse response) {
     response.headers.set("Expires", "Fri, 11 Jun 1999 18:46:53 GMT");
     Date date =
         new Date.withTimeZone(
             1999, Date.JUN, 11, 18, 46, 53, 0, new TimeZone.utc());
     Expect.equals(date, response.headers.expires);
     response.outputStream.close();
   }
 
+  void _contentType1Handler(HttpRequest request, HttpResponse response) {
+    Expect.equals("text/html", request.headers.contentType.value);
+    Expect.equals("text", request.headers.contentType.primaryType);
+    Expect.equals("html", request.headers.contentType.subType);
+    Expect.equals("utf-8", request.headers.contentType.parameters["charset"]);
+
+    response.headers.contentType.value = "text/html";
+    response.headers.contentType.parameters["charset"] = "utf-8";
+    response.outputStream.close();
+  }
+
+  void _contentType2Handler(HttpRequest request, HttpResponse response) {
+    Expect.equals("text/html", request.headers.contentType.value);
+    Expect.equals("text", request.headers.contentType.primaryType);
+    Expect.equals("html", request.headers.contentType.subType);
+    Expect.equals("utf-8", request.headers.contentType.parameters["charset"]);
+
+    response.headers.set(HttpHeaders.CONTENT_TYPE, "text/html;  charset = utf-8");

[Mads Ager (google), 2012/05/21 07:40:39]

Long line. Also multiple long lines below.

[Søren Gjesse, 2012/05/21 11:11:06]

Done.

+    response.outputStream.close();
+  }
+
   void main() {
     // Setup request handlers.
     _requestHandlers = new Map();
     _requestHandlers["/echo"] = (HttpRequest request, HttpResponse response) {
       _echoHandler(request, response);
     };
     _requestHandlers["/0123456789"] =
         (HttpRequest request, HttpResponse response) {
           _zeroToTenHandler(request, response);
         };
     _requestHandlers["/reasonformoving"] =
         (HttpRequest request, HttpResponse response) {
           _reasonForMovingHandler(request, response);
         };
     _requestHandlers["/host"] =
         (HttpRequest request, HttpResponse response) {
           _hostHandler(request, response);
         };
     _requestHandlers["/expires1"] =
         (HttpRequest request, HttpResponse response) {
           _expires1Handler(request, response);
         };
     _requestHandlers["/expires2"] =
         (HttpRequest request, HttpResponse response) {
           _expires2Handler(request, response);
         };
+    _requestHandlers["/contenttype1"] =
+        (HttpRequest request, HttpResponse response) {
+          _contentType1Handler(request, response);
+        };
+    _requestHandlers["/contenttype2"] =
+        (HttpRequest request, HttpResponse response) {
+          _contentType2Handler(request, response);
+        };
 
     this.port.receive((var message, SendPort replyTo) {
       if (message.isStart) {
         _server = new HttpServer();
         try {
           _server.listen("127.0.0.1", 0);
           _server.defaultRequestHandler = (HttpRequest req, HttpResponse rsp) {
             _requestReceivedHandler(req, rsp);
           };
           replyTo.send(new TestServerStatus.started(_server.port), null);
@@ skipping 314 matching lines @@
       processResponse(response);
     };
     HttpClientConnection conn2 = httpClient.get("127.0.0.1", port, "/expires2");
     conn2.onResponse = (HttpClientResponse response) {
       processResponse(response);
     };
   });
   testServerMain.start();
 }
 
+void testContentType() {
+  TestServerMain testServerMain = new TestServerMain();
+  testServerMain.setServerStartedHandler((int port) {
+    int responses = 0;
+    HttpClient httpClient = new HttpClient();
+
+    void processResponse(HttpClientResponse response) {
+      Expect.equals(HttpStatus.OK, response.statusCode);
+      Expect.equals("text/html; charset=utf-8",
+                    response.headers.contentType.toString());
+      Expect.equals("text/html", response.headers.contentType.value);
+      Expect.equals("text", response.headers.contentType.primaryType);
+      Expect.equals("html", response.headers.contentType.subType);
+      Expect.equals("utf-8", response.headers.contentType.parameters["charset"]);
+      responses++;
+      if (responses == 2) {
+        httpClient.shutdown();
+        testServerMain.shutdown();
+      }
+    }
+
+    HttpClientConnection conn1 = httpClient.get("127.0.0.1", port, "/contenttype1");
+    conn1.onRequest = (HttpClientRequest request) {
+      request.headers.contentType.value = "text/html";
+      request.headers.contentType.parameters["charset"] = "utf-8";
+      request.outputStream.close();
+    };
+    conn1.onResponse = (HttpClientResponse response) {
+      processResponse(response);
+    };
+    HttpClientConnection conn2 = httpClient.get("127.0.0.1", port, "/contenttype2");
+    conn2.onRequest = (HttpClientRequest request) {
+      request.headers.set(HttpHeaders.CONTENT_TYPE, "text/html;  charset = utf-8");
+      request.outputStream.close();
+    };
+    conn2.onResponse = (HttpClientResponse response) {
+      processResponse(response);
+    };
+  });
+  testServerMain.start();
+}
+
 
 void main() {
-  testStartStop();
+  /*testStartStop();

[Anders Johnsen, 2012/05/21 07:37:30]

We should still run every test ;)

[Mads Ager (google), 2012/05/21 07:40:39]

Code in comments. 

[Søren Gjesse, 2012/05/21 11:11:06]

Done.

[Søren Gjesse, 2012/05/21 11:11:06]

Done.

   testGET();
   testPOST(true);
   testPOST(false);
   testReadInto(true);
   testReadInto(false);
   testReadShort(true);
   testReadShort(false);
   test404();
   testReasonPhrase();
   testHost();
-  testExpires();
+  testExpires();*/
+  testContentType();
 }