Fix test data push for APK tests.

Fix test data push for APK tests.

test_package.test_suite_basename is used at a lof of places. For APK
tests we need to strip "-debug" from the full test name.
BUG=125059
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137737

[Yaron, 2012-05-17 16:58:32]

lgtm

[commit-bot: I haz the power, 2012-05-17 17:16:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10406030/1

[John Grabowski, 2012-05-17 17:20:06]

LGTM

http://codereview.chromium.org/10406030/diff/1/build/android/test_package.py
File build/android/test_package.py (right):

http://codereview.chromium.org/10406030/diff/1/build/android/test_package.py#...
build/android/test_package.py:40: self.test_suite_basename =
self._GetTestSuiteBaseName()
@property
def test_suite_basename(self):
  return self._GetTestSuiteBaseName()

[nilesh, 2012-05-17 18:43:24]

http://codereview.chromium.org/10406030/diff/1/build/android/test_package.py
File build/android/test_package.py (right):

http://codereview.chromium.org/10406030/diff/1/build/android/test_package.py#...
build/android/test_package.py:40: self.test_suite_basename =
self._GetTestSuiteBaseName()
On 2012/05/17 17:20:06, John Grabowski wrote:
> @property
> def test_suite_basename(self):
>   return self._GetTestSuiteBaseName()

I am new to python, so my understanding may be wrong.
But wouldn't using property will lead to _GetTestSuiteBaseName() being called
everytime test_suite_basename is being referenced. test_suite_basename is a
computed value but it needs to be computed only once.

[John Grabowski, 2012-05-17 19:06:18]

On 2012/05/17 18:43:24, nileshagrawal1 wrote:
> http://codereview.chromium.org/10406030/diff/1/build/android/test_package.py
> File build/android/test_package.py (right):
> 
>
http://codereview.chromium.org/10406030/diff/1/build/android/test_package.py#...
> build/android/test_package.py:40: self.test_suite_basename =
> self._GetTestSuiteBaseName()
> On 2012/05/17 17:20:06, John Grabowski wrote:
> > @property
> > def test_suite_basename(self):
> >   return self._GetTestSuiteBaseName()
> 
> I am new to python, so my understanding may be wrong.
> But wouldn't using property will lead to _GetTestSuiteBaseName() being called
> everytime test_suite_basename is being referenced. test_suite_basename is a
> computed value but it needs to be computed only once.

That's true.

Not a big deal either way which is why I LGTMed.

[commit-bot: I haz the power, 2012-05-17 19:55:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10406030/1

[commit-bot: I haz the power, 2012-05-17 21:20:43]

Change committed as 137737