Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 10406022: Address outstanding comments from CL 10384140 (Closed)

Created:
8 years, 7 months ago by Lambros
Modified:
8 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, erikwright (departed), amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, brettw-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Address outstanding comments from CL 10384140 This adds some clarifying comments, no code-changes here. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M base/base64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/host/me2me_preference_pane.mm View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lambros
rsleevi: ptal wez: remoting/OWNERS stamp
8 years, 7 months ago (2012-05-16 23:38:01 UTC) #1
Ryan Sleevi
lgtm, thanks.
8 years, 7 months ago (2012-05-16 23:45:48 UTC) #2
Wez
lgtm
8 years, 7 months ago (2012-05-17 00:23:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10406022/1
8 years, 7 months ago (2012-05-17 00:58:25 UTC) #4
commit-bot: I haz the power
Presubmit check for 10406022-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-17 00:58:39 UTC) #5
Lambros
mark: base/OWNERS approval please?
8 years, 7 months ago (2012-05-17 01:13:19 UTC) #6
Mark Mentovai
LGTM
8 years, 7 months ago (2012-05-17 13:53:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10406022/1
8 years, 7 months ago (2012-05-17 16:49:42 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 18:35:05 UTC) #9
Change committed as 137695

Powered by Google App Engine
This is Rietveld 408576698