ash: Fix a crash when going back to the main uber-tray popup from the network popup.

ash: Fix a crash when going back to the main uber-tray popup from the network popup.

Going back to the main popup from the network popup causes the network popup to
get destroyed. So trying to access its internals afterwards causes a crash.
Return early to avoid this.

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137681

[Ben Goodger (Google), 2012-05-17 15:58:07]

LGTM

On Wed, May 16, 2012 at 4:12 PM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> ash: Fix a crash when going back to the main uber-tray popup from the
> network
> popup.
>
> Going back to the main popup from the network popup causes the network
> popup to
> get destroyed. So trying to access its internals afterwards causes a crash.
> Return early to avoid this.
>
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/10406020/<http://codereview.chromium.org/104...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/system/network/tray_**network.cc
>
>
> Index: ash/system/network/tray_**network.cc
> diff --git a/ash/system/network/tray_**network.cc
> b/ash/system/network/tray_**network.cc
> index a8f9a0a2856488affb9bf736a2aeea**6f78b3d98a..**
> 6c88fe67eff4766796045faacf83e5**dc7e2e29e4 100644
> --- a/ash/system/network/tray_**network.cc
> +++ b/ash/system/network/tray_**network.cc
> @@ -468,8 +468,10 @@ class NetworkDetailedView : public TrayDetailsView,
>     // on.
>     ResetInfoBubble();
>
> -    if (sender == footer()->content())
> +    if (sender == footer()->content()) {
>       Shell::GetInstance()->tray()->**ShowDefaultView(BUBBLE_USE_**
> EXISTING);
> +      return;
> +    }
>
>     if (login_ == user::LOGGED_IN_LOCKED)
>       return;
>
>
>