Implement Action Box button

chrome/browser/ui/views/location_bar/action_box_button_view.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_
+#pragma once
+
+#include "ui/views/controls/button/menu_button.h"
+#include "ui/views/controls/button/menu_button_listener.h"
+
+class ActionBoxMenu;
+class CommandUpdater;
+
+namespace views {
+class KeyEvent;
+class MouseEvent;
+}
+
+class ActionBoxButtonView : public views::MenuButton,

[not at google - send to devlin, 2012/05/17 23:40:24]

comment with what the action box is, perhaps?

[yefimt, 2012/05/18 00:20:02]

Done.

+                            public views::MenuButtonListener {
+ public:
+  ActionBoxButtonView();
+  virtual ~ActionBoxButtonView();
+
+ private:
+  void SetImages();
+
+  // CustomButton
+  virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
+
+  // MenuButtonListener
+  virtual void OnMenuButtonClicked(View* source,
+                                   const gfx::Point& point) OVERRIDE;

[not at google - send to devlin, 2012/05/17 23:40:24]

Isn't the usual practice to have inherited methods as public?

[Aaron Boodman, 2012/05/17 23:48:35]

No. In fact I prefer them private if they aren't going to be called.

[not at google - send to devlin, 2012/05/17 23:52:03]

They're not going to be called? Am I missing something, or, why would methods
not be called?

[Aaron Boodman, 2012/05/17 23:56:27]

In C++, you can override a virtual method 'privately'. It can be called through
the base class, but not the overriding class.

If the only way a virtual method is going to be called is through a base class,
I prefer to make it private.

The more things are private, the less readers have to worry about who could
potentially be calling something. It reduces the overall cognitive overhead of
understanding the code.

+
+  // Action box menu.
+  scoped_ptr<ActionBoxMenu> action_box_menu_;
+
+  DISALLOW_EVIL_CONSTRUCTORS(ActionBoxButtonView);

[not at google - send to devlin, 2012/05/17 23:40:24]

wot?

Oh, this should be DISALLOW_COPY_AND_ASSIGN, the basictypes.h header says to use
that one instead.

[Aaron Boodman, 2012/05/17 23:48:35]

Whoops, yeah. DISALLOW_EVIL_CONSTRUCTORS was the name used internally at Google,
which is probably why Yefim was familiar with it.

[yefimt, 2012/05/18 00:20:02]

Done.

+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_