Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10406014: Add a ScopedPangoFontDescription helper class and use it. (Closed)

Created:
8 years, 7 months ago by Alexei Svitkine (slow)
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add a ScopedPangoFontDescription helper class and use it. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137555

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -48 lines) Patch
M chrome/browser/ui/gtk/certificate_viewer_gtk.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/font.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/pango_util.h View 2 chunks +21 lines, -0 lines 0 comments Download
M ui/gfx/pango_util.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M ui/gfx/platform_font_pango.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/gfx/platform_font_pango_unittest.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M ui/gfx/render_text_linux.cc View 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
8 years, 7 months ago (2012-05-16 21:11:23 UTC) #1
sky
LGTM
8 years, 7 months ago (2012-05-16 21:36:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10406014/8002
8 years, 7 months ago (2012-05-16 21:48:50 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 23:27:36 UTC) #4
Change committed as 137555

Powered by Google App Engine
This is Rietveld 408576698