Support extension precedences in declarative WebRequest API

Support extension precedences in declarative WebRequest API

This CL introduces precedences of extensions in the same way as they are handled by the old WebRequest API: If two extensions conflict, the most recently installed extension wins.

BUG=112155
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137940

[battre, 2012-05-16 19:39:07]

Please review.

Thanks,
Dominic

[Matt Perry, 2012-05-17 00:42:17]

https://chromiumcodereview.appspot.com/10406013/diff/1/chrome/browser/extensi...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
(right):

https://chromiumcodereview.appspot.com/10406013/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:173:
new WebRequestRulesRegistry(NULL));
could you make these all TestWebRequestRulesRegistry? that would allow you to
remove the special case where it's valid for profile/extension_info_map to be
NULL.

https://chromiumcodereview.appspot.com/10406013/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:316:
LinkedPtrEventResponseDelta winner = *i;
*i++ works too

[battre, 2012-05-18 16:21:39]

Hi Matt,

I have addressed your comments. Please take another look, as you haven't LGTMed
it yet.

Thanks,
Dominic

https://chromiumcodereview.appspot.com/10406013/diff/1/chrome/browser/extensi...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
(right):

https://chromiumcodereview.appspot.com/10406013/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:173:
new WebRequestRulesRegistry(NULL));
On 2012/05/17 00:42:17, Matt Perry wrote:
> could you make these all TestWebRequestRulesRegistry? that would allow you to
> remove the special case where it's valid for profile/extension_info_map to be
> NULL.

Done.

https://chromiumcodereview.appspot.com/10406013/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:316:
LinkedPtrEventResponseDelta winner = *i;
On 2012/05/17 00:42:17, Matt Perry wrote:
> *i++ works too

Done.

[Matt Perry, 2012-05-18 18:53:10]

lgtm

[commit-bot: I haz the power, 2012-05-18 18:55:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10406013/7001

[commit-bot: I haz the power, 2012-05-18 20:16:52]

Change committed as 137940