Issue 10406011: ARM build fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10406011: ARM build fix. (Closed)

Created:
8 years, 7 months ago by Zhenyao Mo

Modified:
8 years, 7 months ago

Reviewers:
robdclark

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, jochen+watch-content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

ARM build fix. On ARM without libpci, vendor_id and device_id will return 0, and we should not disable GPU features because of this. BUG= TEST=ARM bots TBR=sheu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137480

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	content/browser/gpu/gpu_data_manager_impl.cc	View		1 chunk	+2 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robdclark

http://codereview.chromium.org/10406011/diff/1/content/browser/gpu/gpu_data_manager_impl.cc File content/browser/gpu/gpu_data_manager_impl.cc (right): http://codereview.chromium.org/10406011/diff/1/content/browser/gpu/gpu_data_manager_impl.cc#newcode93 content/browser/gpu/gpu_data_manager_impl.cc:93: if (gpu_info.gpu.vendor_id && gpu_info.gpu.device_id) why not handle the blacklist ...

8 years, 7 months ago (2012-05-16 20:35:21 UTC) #1

Zhenyao Mo

8 years, 7 months ago (2012-05-16 20:41:08 UTC) #2

On 2012/05/16 20:35:21, robdclark wrote:
>
http://codereview.chromium.org/10406011/diff/1/content/browser/gpu/gpu_data_m...
> File content/browser/gpu/gpu_data_manager_impl.cc (right):
> 
>
http://codereview.chromium.org/10406011/diff/1/content/browser/gpu/gpu_data_m...
> content/browser/gpu/gpu_data_manager_impl.cc:93: if (gpu_info.gpu.vendor_id &&
> gpu_info.gpu.device_id)
> why not handle the blacklist by GL_VENDER/GL_RENDERER?  (Or fallback to that
on
> devices without PCI?

GL_VENDOR/GL_RENDERER collection requires creating a GL context.

Expand Messages | Collapse Messages