Issue 10406010: Rename aura-notify ash-notify and add to about_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10406010: Rename aura-notify ash-notify and add to about_flags. (Closed)

Created:
8 years, 7 months ago by stevenjb

Modified:
8 years, 7 months ago

Reviewers:
sadrul, Ben Goodger (Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename aura-notify ash-notify and add to about_flags. BUG=124269 TEST=Enable ash-notify in chrome://flags and ensure that ash system notifications for low batter appear instead of desktop notifications TBR=ben for ash/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137465

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -6 lines)			Patch
M	ash/ash_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/ash_switches.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/system/power/tray_power.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/profile_startup.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

We need to be able to enable ash notifications for testing, please review when you ...

8 years, 7 months ago (2012-05-16 18:21:13 UTC) #1

lgtm

Expand Messages | Collapse Messages