Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 10399136: CTX and TMP registers may not be allocated. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/constants_ia32.h ('k') | runtime/vm/locations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 7882)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -58,14 +58,13 @@
LocationSummary* StoreContextComp::MakeLocationSummary() {
LocationSummary* summary = new LocationSummary(1);
- summary->set_in(0, Location::RegisterLocation(CTX));
Vyacheslav Egorov (Google) 2012/05/22 23:25:23 I don't think this change is necessary. This is
srdjan 2012/05/22 23:45:38 How is it known? The register allocator attempts t
srdjan 2012/05/22 23:57:21 Discussed offline and reverted the changes here b
+ summary->set_in(0, Location::RequiresRegister());
return summary;
}
void StoreContextComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- // Nothing to do. Context register were loaded by register allocator.
- ASSERT(locs()->in(0).reg() == CTX);
Vyacheslav Egorov (Google) 2012/05/22 23:25:23 Ditto.
+ __ movq(CTX, locs()->in(0).reg());
}
« no previous file with comments | « runtime/vm/constants_ia32.h ('k') | runtime/vm/locations.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698