Issue 10399134: cros: Maybe fix recent failures on trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399134: cros: Maybe fix recent failures on trunk. (Closed)

Created:
8 years, 7 months ago by Elliot Glaysher

Modified:
8 years, 7 months ago

Reviewers:
jam, Daniel Erat, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

cros: Maybe fix recent failures on trunk. BUG=129075 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138381

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/test/test_renderer_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ui/views/test/views_test_base.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Elliot Glaysher

I wish I had a cros_trunk trybot. (The cros_x86 trybot isn't equivalent to the chromeos ...

8 years, 7 months ago (2012-05-22 20:10:44 UTC) #1

Elliot Glaysher

The linux_aura bot fails with an empty patch too, and win_aura has been hosed for ...

8 years, 7 months ago (2012-05-22 20:40:48 UTC) #2

Elliot Glaysher

Since this is a cros build fix, I'm going to hand commit this right now. ...

8 years, 7 months ago (2012-05-22 22:35:13 UTC) #5

lgtm