Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: remoting/host/server_log_entry_unittest.cc

Issue 10399127: [Chromoting] Replace some bare pointers with scoped_ptrs, and improve naming. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/server_log_entry.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/server_log_entry_unittest.cc
diff --git a/remoting/host/server_log_entry_unittest.cc b/remoting/host/server_log_entry_unittest.cc
index 4f1ac2baf1d60313a11cf10590409300cdcdeae2..2f191068303ce51008b5b0add8f1b2aa0465092f 100644
--- a/remoting/host/server_log_entry_unittest.cc
+++ b/remoting/host/server_log_entry_unittest.cc
@@ -60,9 +60,9 @@ class ServerLogEntryTest : public testing::Test {
}
};
-TEST_F(ServerLogEntryTest, MakeSessionStateChange) {
+TEST_F(ServerLogEntryTest, MakeForSessionStateChange) {
scoped_ptr<ServerLogEntry> entry(
- ServerLogEntry::MakeSessionStateChange(true));
+ ServerLogEntry::MakeForSessionStateChange(true));
scoped_ptr<XmlElement> stanza = entry->ToStanza();
std::string error;
std::map<std::string, std::string> key_value_pairs;
@@ -74,7 +74,7 @@ TEST_F(ServerLogEntryTest, MakeSessionStateChange) {
<< error;
}
-TEST_F(ServerLogEntryTest, MakeHeartbeat) {
+TEST_F(ServerLogEntryTest, MakeForHeartbeat) {
scoped_ptr<ServerLogEntry> entry(ServerLogEntry::MakeForHeartbeat());
scoped_ptr<XmlElement> stanza = entry->ToStanza();
std::string error;
@@ -88,7 +88,7 @@ TEST_F(ServerLogEntryTest, MakeHeartbeat) {
TEST_F(ServerLogEntryTest, AddHostFields) {
scoped_ptr<ServerLogEntry> entry(
- ServerLogEntry::MakeSessionStateChange(true));
+ ServerLogEntry::MakeForSessionStateChange(true));
entry->AddHostFields();
scoped_ptr<XmlElement> stanza = entry->ToStanza();
std::string error;
@@ -116,7 +116,7 @@ TEST_F(ServerLogEntryTest, AddHostFields) {
TEST_F(ServerLogEntryTest, AddModeField1) {
scoped_ptr<ServerLogEntry> entry(
- ServerLogEntry::MakeSessionStateChange(true));
+ ServerLogEntry::MakeForSessionStateChange(true));
entry->AddModeField(ServerLogEntry::IT2ME);
scoped_ptr<XmlElement> stanza = entry->ToStanza();
std::string error;
@@ -132,7 +132,7 @@ TEST_F(ServerLogEntryTest, AddModeField1) {
TEST_F(ServerLogEntryTest, AddModeField2) {
scoped_ptr<ServerLogEntry> entry(
- ServerLogEntry::MakeSessionStateChange(true));
+ ServerLogEntry::MakeForSessionStateChange(true));
entry->AddModeField(ServerLogEntry::ME2ME);
scoped_ptr<XmlElement> stanza = entry->ToStanza();
std::string error;
« no previous file with comments | « remoting/host/server_log_entry.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698