Issue 10399127: [Chromoting] Replace some bare pointers with scoped_ptrs, and improve naming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399127: [Chromoting] Replace some bare pointers with scoped_ptrs, and improve naming. (Closed)

Created:
8 years, 7 months ago by simonmorris

Modified:
8 years, 7 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Chromoting] Replace some bare pointers with scoped_ptrs, and improve naming. This is a follow-up to codereview.chromium.org/10409017 BUG=126491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138331

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -15 lines)			Patch
M	remoting/host/log_to_server.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/server_log_entry.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/host/server_log_entry.cc	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	remoting/host/server_log_entry_unittest.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10399127/1

8 years, 7 months ago (2012-05-22 18:00:01 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-22 19:37:47 UTC) #4

Try job failure for 10399127-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages