Issue 10399120: Add GL_EXPORT for GLContextGLX

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399120: Add GL_EXPORT for GLContextGLX (Closed)

Created:
8 years, 7 months ago by kochi

Modified:
8 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit), apatrick_chromium

CC:
chromium-reviews, dhollowa+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add GL_EXPORT for GLContextGLX This fixes breakage of component_build on ChromeOS BUG=129131 TEST=emerge and run chrome on ChromeOS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138430

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/gl/gl_context_glx.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kochi

Hi, This fixes runtime breakage. Could you check if this is correct?

8 years, 7 months ago (2012-05-22 07:33:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10399120/1

8 years, 7 months ago (2012-05-22 21:51:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10399120/1

8 years, 7 months ago (2012-05-23 04:29:05 UTC) #4

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 04:49:56 UTC) #5

Try job failure for 10399120-1 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages