Issue 10399105: [File Manager] Refresh GDrive thumbnails if they became stale

Issue 10399105: [File Manager] Refresh GDrive thumbnails if they became stale (Closed)

Created:
8 years, 7 months ago by Vladislav Kaznacheev

Modified:
8 years, 7 months ago

Reviewers:
dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[File Manager] Refresh GDrive thumbnails if they became stale BUG=127697 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138103

Patch Set 3 : Addressed comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	5 chunks	+46 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM with comments https://chromiumcodereview.appspot.com/10399105/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10399105/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js#newcode1717 chrome/browser/resources/file_manager/js/file_manager.js:1717: transform: transform, extra comma https://chromiumcodereview.appspot.com/10399105/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js#newcode3725 chrome/browser/resources/file_manager/js/file_manager.js:3725: ...

8 years, 7 months ago (2012-05-21 16:01:16 UTC) #3

Vladislav Kaznacheev

Thanks for the review, committing. https://chromiumcodereview.appspot.com/10399105/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10399105/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js#newcode1717 chrome/browser/resources/file_manager/js/file_manager.js:1717: transform: transform, On 2012/05/21 ...

8 years, 7 months ago (2012-05-21 16:12:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10399105/6001

8 years, 7 months ago (2012-05-21 16:12:52 UTC) #5

commit-bot: I haz the power

8 years, 7 months ago (2012-05-21 16:30:33 UTC) #6

Try job failure for 10399105-6001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages