Issue 10399096: Check for and disallow rules the process the output of other rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399096: Check for and disallow rules the process the output of other rules (Closed)

Created:
8 years, 7 months ago by scottmg

Modified:
8 years, 7 months ago

Reviewers:
Nico, Evan Martin

CC:
gyp-developer_googlegroups.com

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Check for and disallow rules the process the output of other rules Add test/chained-rules/gyptest-chained-rules.py as verification. Per discussion, and in favour of https://chromiumcodereview.appspot.com/10381103/ BUG=127444

Patch Set 1 #

Patch Set 2 : fix comment #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -0 lines)			Patch
M	pylib/gyp/input.py	View	1	2 chunks	+20 lines, -0 lines	1 comment	Download
A	test/chained-rules/chained-rules.gyp	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A	test/chained-rules/gyptest-chained-rules.py	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	test/chained-rules/input.msi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

8 years, 7 months ago (2012-05-18 22:53:36 UTC) #2

punting to thakis, minor comment below

https://chromiumcodereview.appspot.com/10399096/diff/5001/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://chromiumcodereview.appspot.com/10399096/diff/5001/pylib/gyp/input.py#...
pylib/gyp/input.py:2200: processed_outputs.append((rule, output))
Why not a map of output extension => other stuff, so the below bit of code is a
single lookup?

Expand Messages | Collapse Messages