Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: net/http/http_request_headers_unittest.cc

Issue 10399083: Make NetLog take in callbacks that return Values (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix merge error Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_request_headers.cc ('k') | net/http/http_response_headers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_request_headers_unittest.cc
===================================================================
--- net/http/http_request_headers_unittest.cc (revision 141317)
+++ net/http/http_request_headers_unittest.cc (working copy)
@@ -4,6 +4,7 @@
#include "net/http/http_request_headers.h"
+#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
@@ -163,6 +164,24 @@
EXPECT_EQ("B: b\r\nC: c\r\n\r\n", headers.ToString());
}
+TEST(HttpRequestHeaders, ToNetLogParamAndBackAgain) {
+ HttpRequestHeaders headers;
+ headers.SetHeader("B", "b");
+ headers.SetHeader("A", "a");
+ std::string request_line("GET /stuff");
+
+ scoped_ptr<base::Value> event_param(
+ headers.NetLogCallback(&request_line, NetLog::LOG_ALL_BUT_BYTES));
+ HttpRequestHeaders headers2;
+ std::string request_line2;
+
+ ASSERT_TRUE(HttpRequestHeaders::FromNetLogParam(event_param.get(),
+ &headers2,
+ &request_line2));
+ EXPECT_EQ(request_line, request_line2);
+ EXPECT_EQ("B: b\r\nA: a\r\n\r\n", headers2.ToString());
+}
+
} // namespace
} // namespace net
« no previous file with comments | « net/http/http_request_headers.cc ('k') | net/http/http_response_headers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698