Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6107)

Unified Diff: chrome/browser/net/chrome_net_log_unittest.cc

Issue 10399083: Make NetLog take in callbacks that return Values (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix merge error Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/chrome_net_log.cc ('k') | chrome/browser/net/load_timing_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/chrome_net_log_unittest.cc
===================================================================
--- chrome/browser/net/chrome_net_log_unittest.cc (revision 141317)
+++ chrome/browser/net/chrome_net_log_unittest.cc (working copy)
@@ -22,11 +22,7 @@
net_log()->RemoveThreadSafeObserver(this);
}
- virtual void OnAddEntry(net::NetLog::EventType type,
- const base::TimeTicks& time,
- const net::NetLog::Source& source,
- net::NetLog::EventPhase phase,
- net::NetLog::EventParameters* params) OVERRIDE {
+ virtual void OnAddEntry(const net::NetLog::Entry& entry) OVERRIDE {
++count_;
}
@@ -37,7 +33,7 @@
};
void AddEvent(ChromeNetLog* net_log) {
- net_log->AddGlobalEntry(net::NetLog::TYPE_CANCELLED, NULL);
+ net_log->AddGlobalEntry(net::NetLog::TYPE_CANCELLED);
}
// A thread that waits until an event has been signalled before calling
« no previous file with comments | « chrome/browser/net/chrome_net_log.cc ('k') | chrome/browser/net/load_timing_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698