Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 10399078: Nacl sdk automated test(method-testNaClSDK) of new installation process of NaCl sdk. (Closed)

Created:
8 years, 7 months ago by Pooja Nihalani
Modified:
8 years, 7 months ago
Reviewers:
pnihalani1, Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Nacl sdk Nacl sdk automated test(method-testNaClSDK) of new installation process of NaCl sdk. -Changed list of files being checked for NaCl sdk installer. -Changed Download and unziping of nacl_sdk folder on all the platforms(Used Zipfile module). -Changed installation of NaCl SDK. -Removed Hello world examples from test case. -Added new examples like Input Events, Dynamic Library(Magic * ball), Load progress, Multi-threaded input events, Web socket -Fixed pepper and chrome version verification Made changes to run examples only when they match and print a "Incompatibility version" message otherwise. Code Cleanup: -Removed unused methods and pre-defined global variables. -Removed pre-release gallery test.test(method-testNaClSDK) of new installation process of NaCl sdk. -Re-factored code by following DRY(Donot Repeat yourself) principle and by removing redundancies in the code. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -704 lines) Patch
M functional/PYAUTO_TESTS View 2 chunks +0 lines, -6 lines 0 comments Download
M functional/nacl_sdk.py View 16 chunks +317 lines, -698 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Pooja Nihalani
Hello Nirnimesh, Please review my code and let me know if you want me to ...
8 years, 7 months ago (2012-05-17 23:52:30 UTC) #1
Nirnimesh
1. Update the title and description to reflect everything this CL is doing (including what ...
8 years, 7 months ago (2012-05-18 01:31:49 UTC) #2
pnihalani1
8 years, 7 months ago (2012-05-18 15:59:08 UTC) #3
pnihalani1
I have changed description and title. Please let me know if I should make any ...
8 years, 7 months ago (2012-05-21 22:16:06 UTC) #4
Nirnimesh
LGTM Please make sure you're around to ensure that this safely lands, that is please ...
8 years, 7 months ago (2012-05-22 00:52:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pnihalani@chromium.org/10399078/1
8 years, 7 months ago (2012-05-22 15:57:53 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 15:58:12 UTC) #7
Change committed as 138259

Powered by Google App Engine
This is Rietveld 408576698