Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: utils/pub/source.dart

Issue 10399076: Get codebase ready for actually supporting versioning. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tiny tweak. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/source.dart
diff --git a/utils/pub/source.dart b/utils/pub/source.dart
index da01f1214930d47b5c335afc66334e182f770407..1b637b2baa934ef7519a4525ec045056d8334207 100644
--- a/utils/pub/source.dart
+++ b/utils/pub/source.dart
@@ -41,15 +41,12 @@ class Source {
abstract Future<bool> install(PackageId id, String path);
/**
- * Returns the name of the package identified by [id]. By default, this is
- * just `id.fullName`, but some sources (e.g. Git) may have more complicated
- * resolution logic.
- *
- * This method should be light-weight. It doesn't need to validate that the
- * given package exists.
+ * Returns a human-friendly name for the package identified by [id]. This
+ * method should be light-weight. It doesn't need to validate that the given
+ * package exists.
*
* The package name should be lower-case and suitable for use in a filename.
* It may contain forward slashes.
*/
- String packageName(PackageId id) => id.fullName;
+ abstract String packageName(PackageId id);
nweiz 2012/05/18 00:08:24 I feel like id.description is still a good default
Bob Nystrom 2012/05/18 20:02:38 Done.
}

Powered by Google App Engine
This is Rietveld 408576698