Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: utils/pub/sdk_source.dart

Issue 10399076: Get codebase ready for actually supporting versioning. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tiny tweak. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/sdk_source.dart
diff --git a/utils/pub/sdk_source.dart b/utils/pub/sdk_source.dart
index b64fd9c78014a9ce4f0dc8cc83c7005efdfd3566..bffba89c8a168e74da5cda6361b103c1fcc24040 100644
--- a/utils/pub/sdk_source.dart
+++ b/utils/pub/sdk_source.dart
@@ -25,10 +25,12 @@ class SdkSource extends Source {
* involves symlinking the SDK library into the packages directory.
*/
Future<bool> install(PackageId id, String destPath) {
- var sourcePath = join(rootDir, "lib", id.fullName);
+ var sourcePath = join(rootDir, "lib", id.description);
nweiz 2012/05/18 00:08:24 This should validate that id.description is a stri
Bob Nystrom 2012/05/18 20:02:38 Good idea. Done.
return exists(sourcePath).chain((exists) {
if (!exists) return new Future<bool>.immediate(false);
return createSymlink(sourcePath, destPath).transform((_) => true);
});
}
+
+ String packageName(PackageId id) => id.description;
}

Powered by Google App Engine
This is Rietveld 408576698