Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: utils/tests/pub/test_pub.dart

Issue 10399076: Get codebase ready for actually supporting versioning. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Respond to review. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/tests/pub/pubspec_test.dart ('k') | utils/tests/pub/version_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/test_pub.dart
diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart
index 702aa04b4094d56b3243b612da8a98d6c4981257..fdd49247418b05baab09c439846234aae75e1fcb 100644
--- a/utils/tests/pub/test_pub.dart
+++ b/utils/tests/pub/test_pub.dart
@@ -108,8 +108,6 @@ void runPub([List<String> args, Pattern output, int exitCode = 0]) {
return _runPub(args, pathInSandbox(appPath));
}).chain((result) {
- _validateOutput(output, result.stdout);
-
Expect.equals(result.stderr.length, 0,
'Did not expect any output on stderr, and got:\n' +
Strings.join(result.stderr, '\n'));
@@ -117,6 +115,8 @@ void runPub([List<String> args, Pattern output, int exitCode = 0]) {
Expect.equals(result.exitCode, exitCode,
'Pub returned exit code ${result.exitCode}, expected $exitCode.');
+ _validateOutput(output, result.stdout);
+
return _runScheduled(createdSandboxDir, _scheduledAfterPub);
});
« no previous file with comments | « utils/tests/pub/pubspec_test.dart ('k') | utils/tests/pub/version_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698