Issue 10399072: Allow multiple possibe error codes for the "status" parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399072: Allow multiple possibe error codes for the "status" parameter. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Allow multiple possibe error codes for the "status" parameter. Use this to make gyptest-objc-gc pass with both Xcode 3 and 4. Committed: https://code.google.com/p/gyp/source/detail?r=1385

Patch Set 1 #

Total comments: 3

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
	M	test/lib/TestCommon.py	View		1 chunk	+10 lines, -13 lines	3 comments	Download
	M	test/mac/gyptest-objc-gc.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/10399072/diff/1/test/lib/TestCommon.py File test/lib/TestCommon.py (left): https://chromiumcodereview.appspot.com/10399072/diff/1/test/lib/TestCommon.py#oldcode192 test/lib/TestCommon.py:192: if os.name == 'posix': The two branches looked identical ...

8 years, 7 months ago (2012-05-17 20:31:57 UTC) #1

Mark Mentovai

LGTM https://chromiumcodereview.appspot.com/10399072/diff/1/test/lib/TestCommon.py File test/lib/TestCommon.py (right): https://chromiumcodereview.appspot.com/10399072/diff/1/test/lib/TestCommon.py#newcode196 test/lib/TestCommon.py:196: return _status(self) not in status OK to the ...

8 years, 7 months ago (2012-05-17 21:08:58 UTC) #2

Nico

8 years, 7 months ago (2012-05-17 21:29:36 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10399072/diff/1/test/lib/TestCommon.py
File test/lib/TestCommon.py (right):

https://chromiumcodereview.appspot.com/10399072/diff/1/test/lib/TestCommon.py...
test/lib/TestCommon.py:196: return _status(self) not in status
On 2012/05/17 21:08:58, Mark Mentovai wrote:
> OK to the reorganization, but could you be consistent with the indentation?
You
> used 2 here and for the next one, but 4 elsewhere.

Done. Huh, looks like this file doesn't use google style.

Expand Messages | Collapse Messages