Reland 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::…

chrome/browser/extensions/webstore_inline_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_inline_installer.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/string_util.h"
@@ skipping 362 matching lines @@
   // Check if the tab has gone away in the meantime.
   if (!web_contents()) {
     CompleteInstall("");
     return;
   }
 
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
 
   scoped_ptr<WebstoreInstaller::Approval> approval(
-      new WebstoreInstaller::Approval);
-  approval->extension_id = id_;
-  approval->profile = profile;
-  approval->parsed_manifest.reset(manifest_.get()->DeepCopy());
+      WebstoreInstaller::Approval::CreateWithNoInstallPrompt(
+          profile,
+          id_,
+          scoped_ptr<base::DictionaryValue>(manifest_.get()->DeepCopy())));
   approval->use_app_installed_bubble = true;
 
   scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(
       profile, this, &(web_contents()->GetController()), id_, approval.Pass(),
       WebstoreInstaller::FLAG_INLINE_INSTALL);
   installer->Start();
 }
 
 void WebstoreInlineInstaller::InstallUIAbort(bool user_initiated) {
   CompleteInstall(kUserCancelledError);
@@ skipping 49 matching lines @@
       verified_site_pattern.Parse(verified_site_url);
   if (parse_result != URLPattern::PARSE_SUCCESS) {
     DLOG(WARNING) << "Could not parse " << verified_site_url <<
         " as URL pattern " << parse_result;
     return false;
   }
   verified_site_pattern.SetScheme("*");
 
   return verified_site_pattern.MatchesURL(requestor_url);
 }