Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 10399055: ninja: Change the default target from 'build everything' to 'build target "all"'. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com, Evan Martin
Visibility:
Public.

Description

ninja: Change the default target from 'build everything' to 'build target "all"'. 'all' are all targets transitively referenced by all.gyp. For example: all.gyp: targets: [ { 'target_name': 'main_target', 'dependencies': [ 'dep.gyp:target1', ], }, ] dep.gyp: targets: [ { 'target_name': 'target1' }, { 'target_name': 'target2' }, ] Here, 'all' does include target1 from dep.gyp, but not target2. The generator still writes a ninja file for target2, and it can be built with 'ninja target2', but just 'ninja' will no longer build it. BUG=127952 TEST=Running just `ninja -C out/Release` doesn't produce errors. Committed: https://code.google.com/p/gyp/source/detail?r=1380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
I agree it's weird that 'all' doesn't include all targets, but that's not something new ...
8 years, 7 months ago (2012-05-16 21:00:38 UTC) #1
scottmg
lgtm we could probably test that? but not too worried about it since it's sort ...
8 years, 7 months ago (2012-05-16 21:06:39 UTC) #2
Nico
8 years, 7 months ago (2012-05-16 21:08:35 UTC) #3
On 2012/05/16 21:06:39, scottmg wrote:
> lgtm
> 
> we could probably test that? but not too worried about it since it's sort of
> "ui".

agreed

Powered by Google App Engine
This is Rietveld 408576698