Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 10399050: Adding functionality to specify TLS encryption CUPS print servers for cloudprint connector. (Closed)

Created:
8 years, 7 months ago by gene
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding functionality to specify TLS encryption CUPS print servers for cloudprint connector. BUG=127858 TEST=add 'cups_encryption' filed to 'Service State' file in print settings section. Value should be 0..4 (see http_encryption_t for possible values). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137550

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M chrome/service/cloud_print/print_system_cups.cc View 8 chunks +24 lines, -9 lines 1 comment Download
M printing/backend/cups_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/backend/cups_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M printing/backend/print_backend_consts.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/print_backend_consts.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/print_backend_cups.cc View 4 chunks +17 lines, -6 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
gene
8 years, 7 months ago (2012-05-16 18:38:43 UTC) #1
Albert Bodenhamer
lgtm
8 years, 7 months ago (2012-05-16 18:42:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10399050/1
8 years, 7 months ago (2012-05-16 18:47:02 UTC) #3
commit-bot: I haz the power
Change committed as 137550
8 years, 7 months ago (2012-05-16 23:07:39 UTC) #4
Ryan Sleevi
8 years, 7 months ago (2012-05-17 00:35:27 UTC) #5
random post-commit drive-by style nit

https://chromiumcodereview.appspot.com/10399050/diff/1/chrome/service/cloud_p...
File chrome/service/cloud_print/print_system_cups.cc (right):

https://chromiumcodereview.appspot.com/10399050/diff/1/chrome/service/cloud_p...
chrome/service/cloud_print/print_system_cups.cc:141: const char* title, int
num_options, cups_option_t* options);
nit: these too

https://chromiumcodereview.appspot.com/10399050/diff/1/printing/backend/print...
File printing/backend/print_backend_cups.cc (right):

https://chromiumcodereview.appspot.com/10399050/diff/1/printing/backend/print...
printing/backend/print_backend_cups.cc:106: http_encryption_t encryption, bool
blocking);
style nit: put "bool blocking" on a new line, per

http://dev.chromium.org/developers/coding-style

(See "For function declarations and definitions" ...)

Powered by Google App Engine
This is Rietveld 408576698