Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10399049: Replace delay loop by sleep() call. (Closed)

Created:
8 years, 7 months ago by enal
Modified:
8 years, 7 months ago
Reviewers:
DaleCurtis, enal1
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Replace delay loop by sleep() call. As a workaround for crbug.com/128128 we added delay. It is better to explicitly call sleep() than to loop. BUG=128128 TEST=No observable change in behavior, code somewhat cleaner and uses less resources. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137917

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M media/audio/audio_output_controller.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
enal1
Dale, of course I have second thought about yesterday's CL -- explicit sleep() call is ...
8 years, 7 months ago (2012-05-16 17:56:55 UTC) #1
DaleCurtis
lgtm https://chromiumcodereview.appspot.com/10399049/diff/1/media/audio/audio_output_controller.cc File media/audio/audio_output_controller.cc (right): https://chromiumcodereview.appspot.com/10399049/diff/1/media/audio/audio_output_controller.cc#newcode222 media/audio/audio_output_controller.cc:222: if (milliseconds_since_stop < kMacWorkaroundInMilliseconds) { Add milliseconds_since_stop >= ...
8 years, 7 months ago (2012-05-16 20:41:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/10399049/4001
8 years, 7 months ago (2012-05-18 17:33:16 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 18:57:22 UTC) #4
Change committed as 137917

Powered by Google App Engine
This is Rietveld 408576698