Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5058)

Unified Diff: chrome/browser/chromeos/input_method/xkeyboard.cc

Issue 10399046: Remove virtual keyboard support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: final rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/xkeyboard.cc
diff --git a/chrome/browser/chromeos/input_method/xkeyboard.cc b/chrome/browser/chromeos/input_method/xkeyboard.cc
index ecac25640de2ef5f817ba89121595fd3781f00cb..76cfa46968836e2583313ff666554dcdd8d5e3a6 100644
--- a/chrome/browser/chromeos/input_method/xkeyboard.cc
+++ b/chrome/browser/chromeos/input_method/xkeyboard.cc
@@ -145,20 +145,11 @@ XKeyboardImpl::XKeyboardImpl(const InputMethodUtil& util)
std::string layout;
for (size_t i = 0; i < arraysize(kKeepRightAltInputMethods); ++i) {
layout = util.GetKeyboardLayoutName(kKeepRightAltInputMethods[i]);
- // The empty check is necessary since USE_VIRTUAL_KEYBOARD build does not
- // support some of the kKeepRightAltInputMethods elements. For example,
- // when USE_VIRTUAL_KEYBOARD is defined,
- // util.GetKeyboardLayoutName("xkb:us:intl:eng") would return "".
- if (!layout.empty()) {
- keep_right_alt_xkb_layout_names_.insert(layout);
- }
+ keep_right_alt_xkb_layout_names_.insert(layout);
}
for (size_t i = 0; i < arraysize(kCapsLockRemapped); ++i) {
layout = util.GetKeyboardLayoutName(kCapsLockRemapped[i]);
- // The empty check is for USE_VIRTUAL_KEYBOARD build. See above.
- if (!layout.empty()) {
- caps_lock_remapped_xkb_layout_names_.insert(layout);
- }
+ caps_lock_remapped_xkb_layout_names_.insert(layout);
}
}

Powered by Google App Engine
This is Rietveld 408576698