Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: chrome/chrome_installer.gypi

Issue 10399041: Make setup.exe compatible with the component build (2nd try). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use a genexp+str.find() to find the insert_index Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_installer.gypi
diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi
index 852239a743b7f15394db471ac7e3c6dbfb4a75f4..de9deab98a19204fe1b6ea7031bcb4e38ec17459 100644
--- a/chrome/chrome_installer.gypi
+++ b/chrome/chrome_installer.gypi
@@ -324,6 +324,13 @@
},
],
'conditions': [
+ ['component == "shared_library"', {
+ 'msvs_settings': {
+ 'VCManifestTool': {
+ 'EmbedManifest': 'false',
+ },
+ },
+ }],
# TODO(mark): <(branding_dir) should be defined by the
# global condition block at the bottom of the file, but
# this doesn't work due to the following issue:

Powered by Google App Engine
This is Rietveld 408576698