chrome/chrome_exe.gypi - Issue 10399041: Make setup.exe compatible with the component build (2nd try).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_exe.gypi

Issue 10399041: Make setup.exe compatible with the component build (2nd try). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use a genexp+str.find() to find the insert_index Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_exe.gypi

diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi

index 1bb2b178e4105ca6f75ab3f5bfe15b25b5d76afb..f64af02fa3ae5d23c4958e8afbc543a198d23daa 100644

--- a/chrome/chrome_exe.gypi

+++ b/chrome/chrome_exe.gypi

@@ -44,6 +44,13 @@

'INFOPLIST_FILE': 'app/app-Info.plist',

'conditions': [

+ ['component == "shared_library"', {

+ 'msvs_settings': {

+ 'VCManifestTool': {

+ 'EmbedManifest': 'false',

+ },

+ }],

['order_profiling!=0 and (chromeos==1 or OS=="linux")', {

'dependencies' : [

'../tools/cygprofile/cygprofile.gyp:cygprofile',