Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 10399036: Define V8_EXPORT to nothing for clients of v8. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Define V8_EXPORT to nothing for clients of v8. This is to make sure that inline functions are only exported by libv8.so and not also by all clients. This is the v8 version of https://chromiumcodereview.appspot.com/10386108/ This CL depends on http://codereview.chromium.org/10310156/ landing first. BUG=chromium:90078 Committed: https://code.google.com/p/v8/source/detail?r=11590

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M include/v8.h View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
8 years, 7 months ago (2012-05-15 20:35:17 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/10399036/diff/1/include/v8.h File include/v8.h (right): http://codereview.chromium.org/10399036/diff/1/include/v8.h#newcode65 include/v8.h:65: // Setup for Linux shared library export. There ...
8 years, 7 months ago (2012-05-16 07:55:36 UTC) #2
Søren Gjesse
lgtm
8 years, 7 months ago (2012-05-16 08:01:48 UTC) #3
Nico
Thanks! The prerequisite landed in r11586 – could someone land this CL? http://codereview.chromium.org/10399036/diff/1/include/v8.h File include/v8.h ...
8 years, 7 months ago (2012-05-16 16:16:04 UTC) #4
Yang
On 2012/05/16 16:16:04, Nico wrote: > Thanks! > > The prerequisite landed in r11586 – ...
8 years, 7 months ago (2012-05-18 09:48:52 UTC) #5
Yang
8 years, 7 months ago (2012-05-18 09:54:29 UTC) #6
On 2012/05/18 09:48:52, Yang wrote:
> On 2012/05/16 16:16:04, Nico wrote:
> > Thanks!
> > 
> > The prerequisite landed in r11586 – could someone land this CL?
> > 
> > http://codereview.chromium.org/10399036/diff/1/include/v8.h
> > File include/v8.h (right):
> > 
> > http://codereview.chromium.org/10399036/diff/1/include/v8.h#newcode65
> > include/v8.h:65: // Setup for Linux shared library export. There is no need
to
> > distinguish
> > On 2012/05/16 07:55:36, Mads Sig Ager wrote:
> > > Please update the comment as well. :)
> > 
> > Done.
> 
> I'll land this then.

Landed as r11590. Please base your future CLs on svn/bleeding_edge instead of
svn/trunk :)

Powered by Google App Engine
This is Rietveld 408576698