Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 10399018: Fix memory leak. (Closed)

Created:
8 years, 7 months ago by palmer
Modified:
8 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, pam+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M chrome/browser/net/transport_security_persister_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
palmer
jar and bruening as chrome/browser/net OWNERs, thestig as memory guy. Thanks!
8 years, 7 months ago (2012-05-14 23:05:12 UTC) #1
Lei Zhang
Suppression removal LGTM, assuming the fix works.
8 years, 7 months ago (2012-05-14 23:09:25 UTC) #2
jar (doing other things)
Fix looks plausible... and safe... so.... If it works... LGTM.
8 years, 7 months ago (2012-05-14 23:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/10399018/1
8 years, 7 months ago (2012-05-15 17:47:22 UTC) #4
commit-bot: I haz the power
Can't apply patch for file tools/valgrind/memcheck/suppressions.txt. While running patch -p0 --forward --force; patching file tools/valgrind/memcheck/suppressions.txt ...
8 years, 7 months ago (2012-05-15 17:47:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/10399018/2002
8 years, 7 months ago (2012-05-15 18:05:50 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 19:59:27 UTC) #7
Change committed as 137214

Powered by Google App Engine
This is Rietveld 408576698