Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10399017: improved tap suppression change (Closed)

Created:
8 years, 7 months ago by rjkroege
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

improved tap suppression change The touchpad can deliver multiple GestureFlingCancel events within the time window in which we would like to continue to suppress mouse events after the GFC that actually halted the in-progress fling. This change makes the TapSuppressionController stop resetting its state machine on the receipt of such events such that tap suppression continues throughout the time window following a fling-cancelling GFC regardless of intervening GFC events. BUG=122043 TEST=by hand Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/renderer_host/tap_suppression_controller_aura.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rjkroege
8 years, 7 months ago (2012-05-14 22:34:23 UTC) #1
sky
LGTM
8 years, 7 months ago (2012-05-14 23:21:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10399017/1
8 years, 7 months ago (2012-05-15 13:39:00 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 16:16:17 UTC) #4
Change committed as 137150

Powered by Google App Engine
This is Rietveld 408576698