Remove system-provided temporary directory usage from test scripts.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 28 matching lines @@
  * Most TestSuites represent a directory or directory tree containing tests,
  * and a status file containing the expected results when these tests are run.
  */
 interface TestSuite {
   /**
    * Call the callback function onTest with a [TestCase] argument for each
    * test in the suite.  When all tests have been processed, call [onDone].
    *
    * The [testCache] argument provides a persistent store that can be used to
    * cache information about the test suite, so that directories do not need
-   * to be listed each time.  If the tests require a temporary directory for
-   * their files, they can get one from [globalTempDir].
+   * to be listed each time.
    */
-  void forEachTest(Function onTest, Map testCache, String globalTempDir(),
-                   [Function onDone]);
+  void forEachTest(Function onTest, Map testCache, [Function onDone]);
 }
 
 
 class CCTestListerIsolate extends Isolate {
   CCTestListerIsolate() : super.heavy();
 
   void main() {
     port.receive((String runnerPath, SendPort replyTo) {
       var p = Process.start(runnerPath, ["--list"]);
       StringInputStream stdoutStream = new StringInputStream(p.stdout);
@@ skipping 80 matching lines @@
       args.addAll(TestUtils.standardOptions(configuration));
 
       doTest(new TestCase(constructedName,
                           [new Command(runnerPath, args)],
                           configuration,
                           completeHandler,
                           expectations));
     }
   }
 
-  void forEachTest(Function onTest, Map testCache, String globalTempDir(),
-                   [Function onDone]) {
+  void forEachTest(Function onTest, Map testCache, [Function onDone]) {
     doTest = onTest;
     doDone = (ignore) => (onDone != null) ? onDone() : null;
 
     var filesRead = 0;
     void statusFileRead() {
       filesRead++;
       if (filesRead == statusFilePaths.length) {
         receiveTestName = new ReceivePort();
         new CCTestListerIsolate().spawn().then((port) {
             port.send(runnerPath, receiveTestName.toSendPort());
@@ skipping 40 matching lines @@
   String suiteName;
   String directoryPath;
   List<String> statusFilePaths;
   Function doTest;
   Function doDone;
   int activeTestGenerators = 0;
   bool listingDone = false;
   TestExpectations testExpectations;
   List<TestInformation> cachedTests;
   final String dartDir;
-  Function globalTemporaryDirectory;
   Predicate<String> isTestFilePredicate;
   bool _listRecursive;
 
   StandardTestSuite(Map this.configuration,
                     String this.suiteName,
                     String this.directoryPath,
                     List<String> this.statusFilePaths,
                     [Predicate<String> this.isTestFilePredicate,
                     bool recursive = false])
     : dartDir = TestUtils.dartDir(), _listRecursive = recursive;
@@ skipping 46 matching lines @@
 
     return filename.endsWith("Test.dart");
   }
 
   bool listRecursively() => _listRecursive;
 
   String shellPath() => TestUtils.dartShellFileName(configuration);
 
   List<String> additionalOptions(String filename) => [];
 
-  void forEachTest(Function onTest, Map testCache, String globalTempDir(),
-                   [Function onDone = null]) {
+  void forEachTest(Function onTest, Map testCache, [Function onDone = null]) {
     // If DumpRenderTree/Dartium is required, and not yet updated,
     // wait for update.
     var updater = runtimeUpdater(configuration);
     if (updater !== null && !updater.updated) {
       Expect.isTrue(updater.isActive);
       updater.onUpdated.add(() {
-        forEachTest(onTest, testCache, globalTempDir, onDone);
+        forEachTest(onTest, testCache, onDone);
       });
       return;
     }
 
     doTest = onTest;
     doDone = (onDone != null) ? onDone : (() => null);
-    globalTemporaryDirectory = globalTempDir;
 
     var filesRead = 0;
     void statusFileRead() {
       filesRead++;
       if (filesRead == statusFilePaths.length) {
         // Checked if we have already found and generated the tests for
         // this suite.
         if (!testCache.containsKey(suiteName)) {
           cachedTests = testCache[suiteName] = [];
           processDirectory();
@@ skipping 399 matching lines @@
         Expect.fail('unimplemented compiler $compiler');
     }
     if (executable.endsWith('.dart')) {
       // Run the compiler script via the Dart VM.
       args.insertRange(0, 1, executable);
       executable = TestUtils.dartShellFileName(configuration);
     }
     return new Command(executable, args);
   }
 
-  bool get requiresCleanTemporaryDirectory() =>
-      configuration['compiler'] == 'dartc';
-
   /**
    * Create a directory for the generated test.  If a Dart language test
    * needs to be run in a browser, the Dart test needs to be embedded in
    * an HTML page, with a testing framework based on scripting and DOM events.
-   * These scripts and pages are written to a generated_test directory,
-   * usually inside the build directory of the checkout.
-   *
-   * Some tests, such as those using the dartc compiler, need to be run
-   * with an empty directory as the compiler's work directory.  These
-   * tests are copied to a subdirectory of a system-provided temporary
-   * directory, which is deleted at the end of the test run unless the
-   * --keep-temporary-files flag is given.
+   * These scripts and pages are written to a generated_test directory
+   * inside the build directory of the checkout.
    *
    * Those tests which are already HTML web applications (web tests), with
    * resources including CSS files and HTML files, need to be compiled into
    * a work directory where the relative URLS to the resources work.
    * We use a subdirectory of the build directory that is the same number
    * of levels down in the checkout as the original path of the web test.
    */
   Directory createOutputDirectory(String testPath, String optionsName) {
     String testUniqueName =
         testPath.substring(dartDir.length + 1, testPath.length - 5);
     testUniqueName = testUniqueName.replaceAll('/', '_');
     if (!optionsName.isEmpty()) {
       testUniqueName += '-$optionsName';
     }
 
     // Create '[build dir]/generated_tests/$compiler-$runtime/$testUniqueName',
     // including any intermediate directories that don't exist.
     var generatedTestPath = ['generated_tests',
                              configuration['compiler'] + '-' +
                              configuration['runtime'],
                              testUniqueName];
 
     String tempDirPath = TestUtils.buildDir(configuration);
-    if (requiresCleanTemporaryDirectory) {
-      tempDirPath = globalTemporaryDirectory();
-      String debugMode =
-          (configuration['mode'] == 'debug') ? 'Debug_' : 'Release_';
-      var temp = ['${debugMode}_${configuration["arch"]}'];
-      temp.addAll(generatedTestPath);
-      generatedTestPath = temp;
-    }
     Directory tempDir = new Directory(tempDirPath);
     if (!tempDir.existsSync()) {
+      // TODO(whesse): Replace this with mkdirRecursive.
       // Dartium tests can be run with no build step, with no output directory.
       // This special case builds the build directory that should be there.
       var buildPath = tempDirPath.split('/');
       tempDirPath = buildPath[0];
       if (tempDirPath == '') {
         throw new Exception(
             'Non-relative path to build directory in test_suite.dart');
       }
       if (buildPath.length > 1) {
         buildPath.removeRange(0, 1);
@@ skipping 311 matching lines @@
                  String this.directoryPath,
                  String this.statusFilePath)
       : dartDir = TestUtils.dartDir();
 
   bool isTestFile(String filename) => filename.endsWith("Tests.java") &&
       !filename.contains('com/google/dart/compiler/vm') &&
       !filename.contains('com/google/dart/corelib/SharedTests.java');
 
   void forEachTest(Function onTest,
                    Map testCacheIgnored,
-                   String globalTempDir(),
                    [Function onDone = null]) {
     doTest = onTest;
     doDone = (onDone != null) ? onDone : (() => null);
 
     if (configuration['compiler'] != 'dartc') {
       // Do nothing.  Asynchronously report that the suite is enqueued.
       new Timer(0, (timerUnused){ doDone(); });
       return;
     }
     RegExp pattern = configuration['selectors']['dartc'];
@@ skipping 295 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }