Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 10398054: Improve documentation of potential memory leaks in URLMatcherFactory (Closed)

Created:
8 years, 7 months ago by battre
Modified:
8 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Improve documentation of potential memory leaks in URLMatcherFactory BUG=112155 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/common/extensions/matcher/url_matcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/matcher/url_matcher_factory.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
8 years, 7 months ago (2012-05-16 13:10:10 UTC) #1
Matt Perry
LGTM (Feel free to TBR changes like this)
8 years, 7 months ago (2012-05-16 23:33:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10398054/1
8 years, 7 months ago (2012-05-16 23:34:22 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 01:57:18 UTC) #4
Change committed as 137609

Powered by Google App Engine
This is Rietveld 408576698