Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: sync/notifier/p2p_notifier.h

Issue 10398051: [Sync] Replace TalkMediator*/MediatorThread* with PushClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/p2p_notifier.h
diff --git a/sync/notifier/p2p_notifier.h b/sync/notifier/p2p_notifier.h
index 093d0232e74516317f4152883fd0a717685180a2..5fc307495c2e69176145d96aad74b24b06f3ac99 100644
--- a/sync/notifier/p2p_notifier.h
+++ b/sync/notifier/p2p_notifier.h
@@ -14,7 +14,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/observer_list.h"
-#include "jingle/notifier/listener/talk_mediator.h"
+#include "jingle/notifier/listener/push_client.h"
#include "sync/notifier/sync_notifier.h"
#include "sync/syncable/model_type.h"
@@ -81,17 +81,17 @@ class P2PNotificationData {
class P2PNotifier
: public SyncNotifier,
- public notifier::TalkMediator::Delegate {
+ public notifier::PushClient::Observer {
public:
- // Takes ownership of |talk_mediator|, but it is guaranteed that
- // |talk_mediator| is destroyed only when this object is destroyed.
+ // Takes ownership of |push_client|, but it is guaranteed that
+ // |push_client| is destroyed only when this object is destroyed.
//
// The |send_notification_target| parameter was added to allow us to send
// self-notifications in some cases, but not others. The value should be
// either NOTIFY_ALL to send notifications to all clients, or NOTIFY_OTHERS
// to send notificaitons to all clients except for the one that triggered the
// notification. See crbug.com/97780.
- P2PNotifier(notifier::TalkMediator* talk_mediator,
+ P2PNotifier(notifier::PushClient* push_client,
P2PNotificationTarget send_notification_target);
virtual ~P2PNotifier();
@@ -108,11 +108,10 @@ class P2PNotifier
virtual void SendNotification(
syncable::ModelTypeSet changed_types) OVERRIDE;
- // TalkMediator::Delegate implementation.
+ // PushClient::Delegate implementation.
virtual void OnNotificationStateChange(bool notifications_enabled) OVERRIDE;
virtual void OnIncomingNotification(
const notifier::Notification& notification) OVERRIDE;
- virtual void OnOutgoingNotification() OVERRIDE;
// For testing.
void SendNotificationDataForTest(
@@ -124,12 +123,12 @@ class P2PNotifier
ObserverList<SyncNotifierObserver> observer_list_;
// The actual notification listener.
- scoped_ptr<notifier::TalkMediator> talk_mediator_;
+ scoped_ptr<notifier::PushClient> push_client_;
// Our unique ID.
std::string unique_id_;
- // Whether we called Login() on |talk_mediator_| yet.
+ // Whether we have called UpdateCredentials() yet.
bool logged_in_;
- // Whether |talk_mediator_| has notified us that notifications are
+ // Whether |push_client_| has notified us that notifications are
// enabled.
bool notifications_enabled_;
// Which set of clients should be sent notifications.

Powered by Google App Engine
This is Rietveld 408576698