Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 10398049: Put commandline for apk tests in /data/local/tmp (Closed)

Created:
8 years, 7 months ago by nilesh
Modified:
8 years, 7 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Put commandline for apk tests in /data/local/tmp We were trying to use the application directory which is not usually writable (unless the device is rooted). This allows us to run the tests on non-rooted devices. BUG=125059 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/android/test_package_apk.py View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test_launcher.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nilesh
8 years, 7 months ago (2012-05-16 01:10:03 UTC) #1
John Grabowski
Doc this cmd line location somewhere (e.g. dev.chromium.org) LGTM
8 years, 7 months ago (2012-05-16 01:15:31 UTC) #2
Yaron
lgtm
8 years, 7 months ago (2012-05-16 01:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10398049/1
8 years, 7 months ago (2012-05-16 04:29:15 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 05:50:21 UTC) #5
Change committed as 137368

Powered by Google App Engine
This is Rietveld 408576698