Issue 10397003: Minor improvements for key_rewriter.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10397003: Minor improvements for key_rewriter.cc. (Closed)

Created:
8 years, 7 months ago by Yusuke Sato

Modified:
8 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Minor improvements for key_rewriter.cc. - Use VKEY_CONTROL instead of VKEY_LCONTROL/VKEY_RCONTROL to be consistent with Windows' behavior. Windows (and ui/base/keycodes/keyboard_code_conversion_x.cc) never sends a VKEY_[LR]CONTROL event when left/right control is pressed. The VKs are used only as a return value of GetKeyboardState() Windows API. - Add unit tests for Command+NumPad presses. Add tests that checks if NumPad1 + Command key presses on an Apple keyboard are treated as VKEY_NUMPAD1 with EF_CONTROL_DOWN. BUG=None TEST=manual + unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137621

Patch Set 1 #

Patch Set 2 : review #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -92 lines)			Patch
M	chrome/browser/ui/views/ash/key_rewriter.h	View	1	3 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/ash/key_rewriter.cc	View	1	7 chunks	+44 lines, -48 lines	0 comments	Download
M	chrome/browser/ui/views/ash/key_rewriter_unittest.cc	View	1	34 chunks	+73 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10397003/2001

8 years, 7 months ago (2012-05-17 01:15:22 UTC) #3

Change committed as 137621

Expand Messages | Collapse Messages