Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2526)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 103943006: Let MetricsService know about some Android Activities (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Copyright Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index 98543ebe40ed246c747dfdaf1cb586fdbb4dcee7..0307d6ca5f01b76b881e7f646a441f9daa81a80d 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -466,6 +466,10 @@ void MetricsService::RegisterPrefs(PrefRegistrySimple* registry) {
registry->RegisterInt64Pref(prefs::kUninstallMetricsUptimeSec, 0);
registry->RegisterInt64Pref(prefs::kUninstallLastLaunchTimeSec, 0);
registry->RegisterInt64Pref(prefs::kUninstallLastObservedRunTimeSec, 0);
+
+#if defined(OS_ANDROID)
+ RegisterPrefsAndroid(registry);
+#endif // defined(OS_ANDROID)
}
// static
@@ -494,6 +498,10 @@ void MetricsService::DiscardOldStabilityStats(PrefService* local_state) {
local_state->ClearPref(prefs::kMetricsInitialLogs);
local_state->ClearPref(prefs::kMetricsOngoingLogs);
+
+#if defined(OS_ANDROID)
+ DiscardOldStabilityStatsAndroid(local_state);
+#endif // defined(OS_ANDROID)
}
MetricsService::MetricsService()
@@ -927,6 +935,10 @@ void MetricsService::InitializeMetricsState() {
// Stability bookkeeping
IncrementPrefValue(prefs::kStabilityLaunchCount);
+#if defined(OS_ANDROID)
+ RecordAndroidStabilityPrefs();
+#endif // defined(OS_ANDROID)
Ilya Sherman 2013/12/16 23:54:59 I think this line needs to be moved after Alexei's
gone 2013/12/17 01:34:31 I guess something definitely has to be done for th
+
if (!pref->GetBoolean(prefs::kStabilityExitedCleanly)) {
IncrementPrefValue(prefs::kStabilityCrashCount);
// Reset flag, and wait until we call LogNeedForCleanShutdown() before
@@ -1241,6 +1253,9 @@ void MetricsService::CloseCurrentLog() {
current_log->RecordStabilityMetrics(GetIncrementalUptime(pref),
MetricsLog::ONGOING_LOG);
+#if defined(OS_ANDROID)
+ RecordAndroidStabilityHistograms();
+#endif // defined(OS_ANDROID)
RecordCurrentHistograms();
log_manager_.FinishCurrentLog();

Powered by Google App Engine
This is Rietveld 408576698