Let MetricsService know about some Android Activities

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
 namespace prefs {
@@ skipping 1475 matching lines @@
 
 // On Chrome OS, total number of kernel crashes since the last report.
 const char kStabilityKernelCrashCount[] =
     "user_experience_metrics.stability.kernel_crash_count";
 
 // On Chrome OS, total number of unclean system shutdowns since the
 // last report.
 const char kStabilitySystemUncleanShutdownCount[] =
     "user_experience_metrics.stability.system_unclean_shutdowns";
 
+#if defined(OS_ANDROID)
+// ID of the Activity that is currently in the foreground.

[Alexei Svitkine (slow), 2013/12/23 16:28:01]

What kind of ID and how is it stored (string / int)? Document this.

[gone, 2013/12/28 01:33:14]

Done.

+const char kStabilityForegroundActivityType[] =
+    "user_experience_metrics.stability.foreground_activity";
+
+// ORed set of flags indicating which Activities were launched during the

[Alexei Svitkine (slow), 2013/12/23 16:28:01]

Which flags? Can you point to the corresponding constants/enums in the code in
this comment?

[gone, 2013/12/28 01:33:14]

Done.

+// last session.
+const char kStabilityLaunchedActivityFlags[] =
+    "user_experience_metrics.stability.launched_activity_flags";
+
+// Counts how many times the main browser Activity was launched.
+const char kStabilityLaunchCountMainActivity[] =
+    "user_experience_metrics.stability.launch_count_main_activity";

[Alexei Svitkine (slow), 2013/12/23 16:28:01]

Instead of special casing main activity, full screen activity, etc, would it
make more sense to use a list item here, where each entry has activity_type,
launch_count, crash_count, is_foreground? Seems like that would be cleaner and
more extensible in the future. (See how we store plugins for UMA stability for
an example of this).

[gone, 2013/12/28 01:33:14]

Which activity is in a singular value; only one can be in the foreground at any
given time.  It gets translated to a crash state later.  I've switched to lists
otherwise; thanks for the heads up.

+
+// Counts how many times a FullScreenActivity was launched.
+const char kStabilityLaunchCountFullScreenActivity[] =
+    "user_experience_metrics.stability.launch_count_full_screen_activity";
+
+// Counts how many times the main browser Activity crashed.
+const char kStabilityCrashCountMainActivity[] =
+    "user_experience_metrics.stability.crash_count_main_activity";
+
+// Counts how many times a FullScreenActivity crashed.
+const char kStabilityCrashCountFullScreenActivity[] =
+    "user_experience_metrics.stability.crash_count_full_screen_activity";
+#endif
+
 // Number of times the browser has been able to register crash reporting.
 const char kStabilityBreakpadRegistrationSuccess[] =
     "user_experience_metrics.stability.breakpad_registration_ok";
 
 // Number of times the browser has failed to register crash reporting.
 const char kStabilityBreakpadRegistrationFail[] =
     "user_experience_metrics.stability.breakpad_registration_fail";
 
 // Number of times the browser has been run under a debugger.
 const char kStabilityDebuggerPresent[] =
@@ skipping 1167 matching lines @@
 const char kOsPasswordBlank[] = "password_manager.os_password_blank";
 
 // The number of seconds since epoch that the OS password was last changed.
 const char kOsPasswordLastChanged[] =
     "password_manager.os_password_last_changed";
 #endif
 
 // Whether DNS Quick Check is disabled in proxy resolution.
 const char kQuickCheckEnabled[] = "proxy.quick_check_enabled";
 }  // namespace prefs