Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Side by Side Diff: build/common.gypi

Issue 10392194: Fix "unknown argument" message from clang plugin on ChromeOS build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 }, 1096 },
1097 'conditions': [ 1097 'conditions': [
1098 ['chromeos==1', { 1098 ['chromeos==1', {
1099 # TODO(rsleevi): http://crbug.com/123295 - Disabled on ChromeOS 1099 # TODO(rsleevi): http://crbug.com/123295 - Disabled on ChromeOS
1100 # for now. 1100 # for now.
1101 'clang_chrome_plugins_flags': [ 1101 'clang_chrome_plugins_flags': [
1102 '<@(clang_chrome_plugins_flags)', 1102 '<@(clang_chrome_plugins_flags)',
1103 '-Xclang', 1103 '-Xclang',
1104 '-plugin-arg-find-bad-constructs', 1104 '-plugin-arg-find-bad-constructs',
1105 '-Xclang', 1105 '-Xclang',
1106 '-skip-refcounted-dtors' 1106 'skip-refcounted-dtors'
1107 ], 1107 ],
1108 }, { 1108 }, {
1109 'clang_chrome_plugins_flags': [ 1109 'clang_chrome_plugins_flags': [
1110 '<@(clang_chrome_plugins_flags)', 1110 '<@(clang_chrome_plugins_flags)',
1111 ], 1111 ],
1112 }], 1112 }],
1113 ], 1113 ],
1114 }], 1114 }],
1115 1115
1116 # Set use_ibus to 1 to enable ibus support. 1116 # Set use_ibus to 1 to enable ibus support.
(...skipping 2000 matching lines...) Expand 10 before | Expand all | Expand 10 after
3117 # settings in target dicts. SYMROOT is a special case, because many other 3117 # settings in target dicts. SYMROOT is a special case, because many other
3118 # Xcode variables depend on it, including variables such as 3118 # Xcode variables depend on it, including variables such as
3119 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3119 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3120 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3120 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3121 # files to appear (when present) in the UI as actual files and not red 3121 # files to appear (when present) in the UI as actual files and not red
3122 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3122 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3123 # and therefore SYMROOT, needs to be set at the project level. 3123 # and therefore SYMROOT, needs to be set at the project level.
3124 'SYMROOT': '<(DEPTH)/xcodebuild', 3124 'SYMROOT': '<(DEPTH)/xcodebuild',
3125 }, 3125 },
3126 } 3126 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698